[PATCH] ieee1394: sbp2: lower block queue alignment requirement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The old setting seems to be copy & paste from usb-storage.

Signed-off-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx>
---

I wonder, do we need this call to blk_queue_dma_alignment() at all?
Does the block layer perhaps provide sufficient alignment guarantees?


Index: linux/drivers/ieee1394/sbp2.c
===================================================================
--- linux.orig/drivers/ieee1394/sbp2.c	2007-01-14 18:40:08.000000000 +0100
+++ linux/drivers/ieee1394/sbp2.c	2007-01-14 19:30:42.000000000 +0100
@@ -2012,7 +2012,10 @@ static int sbp2scsi_slave_configure(stru
 {
 	struct sbp2_lu *lu = (struct sbp2_lu *)sdev->host->hostdata[0];
 
-	blk_queue_dma_alignment(sdev->request_queue, (512 - 1));
+	/* Page table elements shall be octlet-aligned.
+	 * Everything else can be quadlet-aligned. */
+	blk_queue_dma_alignment(sdev->request_queue, 7);
+
 	sdev->use_10_for_rw = 1;
 
 	if (sdev->type == TYPE_ROM)

-- 
Stefan Richter
-=====-=-=== ---= -===-
http://arcgraph.de/sr/

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux