On 4/28/20 11:29 AM, Bart Van Assche wrote: > On 2020-04-27 23:11, Mike Christie wrote: >> @@ -3536,6 +3551,15 @@ static int __init target_core_init_configfs(void) >> >> target_init_dbroot(); >> >> + tcm_core_kobj = kobject_create_and_add("scsi_target", NULL); >> + if (!tcm_core_kobj) >> + goto out; > > Is an ack from Greg KH required when adding a new directory under > /sys/kernel? I'm not sure. When I resend with your other comments handled, I will cc him.