On 2020-04-27 23:11, Mike Christie wrote: > @@ -3536,6 +3551,15 @@ static int __init target_core_init_configfs(void) > > target_init_dbroot(); > > + tcm_core_kobj = kobject_create_and_add("scsi_target", NULL); > + if (!tcm_core_kobj) > + goto out; Is an ack from Greg KH required when adding a new directory under /sys/kernel? Should a file be added under Documentation/ABI/stable that documents the new sysfs attributes? Otherwise this patch looks fine to me. Thanks, Bart.