On 4/27/20 7:25 PM, Finn Thain wrote:
On Mon, 27 Apr 2020, himanshu.madhani@xxxxxxxxxx wrote:
This looks okay, but i would strongly suggest driver maintainer to
verify if this introduces any regression or not.
If the changes don't affect code generation, regression is impossible.
So, compilers (and cross-compilers) could answer your question, if they
could achieve sufficient code coverage.
Agree if the code generation does not change then there should be no
regression.
It would be nice if there was a tag that could be added to a patch so that
CI services could check for compiler output invariance (.s or .i or both).
This sounds like a good idea for CI service to check for compiler output
and make sure patch does not break it.
Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
--
Himanshu Madhani
Oracle Linux Engineering
