Re: [PATCH] qla2xxx: correct locking while call starget_for_each_device()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 09 Jan 2007, Matthew Wilcox wrote:

> On Tue, Jan 09, 2007 at 11:37:52AM -0800, Seokmann Ju wrote:
> > Removed spin_unlock_irq()/spin_lock_irq() pairs surrounding
> > starget_for_each_device() calls.
> > As Matthew W. pointed out, starget_for_each_device() can be called under
> > a spinlock being held.
> > The change has been tested and verified on qla2xxx.ko module.
> 
> Did you try it with lockdep enabled?  I worry about an AB-BA deadlock.

Yes, from .config

	...
	CONFIG_LOCKDEP_SUPPORT=y

Thanks again for the hint...
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux