On Tue, Jan 09, 2007 at 11:37:52AM -0800, Seokmann Ju wrote: > Removed spin_unlock_irq()/spin_lock_irq() pairs surrounding > starget_for_each_device() calls. > As Matthew W. pointed out, starget_for_each_device() can be called under > a spinlock being held. > The change has been tested and verified on qla2xxx.ko module. Did you try it with lockdep enabled? I worry about an AB-BA deadlock. - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html