Re: [PATCH] scsi: sg: fix memory leak in sg_build_indirect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-04-13 3:35 p.m., Markus Elfring wrote:
Fix a memory leak when there have failed, that we should free the pages
under the condition rem_sz > 0.

I suggest to improve the change description.

* Please use an imperative wording.

nominative, vocative, accusative, genitive ...

I have made some comment suggestions in response to the original posts
from the author.

* Will the tag “Fixes” become relevant?

Yes, both patches from the author are fixes. These leaks would typically
appear on a system under resource pressure (specifically low memory) and
would tend to make the situation worse.

Doug Gilbert





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux