Re: [PATCH] scsi: sg: fix memory leak in sg_build_indirect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Li Bin <huawei.libin@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] scsi: sg: fix memory leak in sg_build_indirect
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Mon, 13 Apr 2020 21:35:43 +0200
Cc: linux-kernel@xxxxxxxxxxxxxxx, Doug Gilbert <dgilbert@xxxxxxxxxxxx>, "James E. J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Xie XiuQi <xiexiuqi@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0

> Fix a memory leak when there have failed, that we should free the pages
> under the condition rem_sz > 0.

I suggest to improve the change description.

* Please use an imperative wording.

* Will the tag “Fixes” become relevant?

Regards,
Markus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH] scsi: sg: fix memory leak in sg_build_indirect
  - From: Douglas Gilbert

Prev by Date: Re: [PATCH 23/35] docs: fusion: mptbase.c: get rid of a doc build warning
Next by Date: [PATCH 1/2] mm, treewide: Rename kzfree() to kfree_sensitive()
Previous by thread: Re: [PATCH] scsi: sg: fix memory leak in sg_build_indirect
Next by thread: Re: [PATCH] scsi: sg: fix memory leak in sg_build_indirect
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]

Powered by Linux