On Wed, Feb 05, 2020 at 10:44:21PM +0100, mwilck@xxxxxxxx wrote:
> From: Martin Wilck <mwilck@xxxxxxxx>
>
> Since 45235022da99, the firmware is shut down early in the controller
> shutdown process. This causes commands sent to the firmware (such as LOGO)
> to hang forever. Eventually one or more timeouts will be triggered.
> Move the stopping of the firmware until after sessions have terminated.
>
> Fixes: 45235022da99 ("scsi: qla2xxx: Fix driver unload by shutting down chip")
> Signed-off-by: Martin Wilck <mwilck@xxxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 21 ++++++++++-----------
> 1 file changed, 10 insertions(+), 11 deletions(-)
>
Hi Martin,
Reviewed-by: Roman Bolshakov <r.bolshakov@xxxxxxxxx>
BTW, I think qla_nvme_delete() should be moved up to split the function into
two parts:
* session/port cleanup
* chip shutdown
Although invocation of the function after chip shutdown has no functional
implications at the moment.
Best regards,
Roman
