On 2020-03-13 02:15, Andy Shevchenko wrote: > On Thu, Mar 12, 2020 at 07:37:16PM -0700, Bart Van Assche wrote: >> +static inline void __put_unaligned_be24(u32 val, u8 *p) > > const u32 val Hi Andy, Thanks for the review. The above suggestion surprises me: as far as I can tell almost nobody declares function arguments that are passed by value as 'const' in the Linux kernel: $ git grep -nH '(const[^\*,]*,' | wc -l 1065 That number is negligible compared to the number of function declarations: $ git grep -nH '(.*);$' | wc -l 2692721 Thanks, Bart.