On 2/26/20 6:45 PM, Christoph Hellwig wrote:
+/**
+ * scsi_host_busy_iter - Iterate over all busy commands
+ * @shost: Pointer to Scsi_Host.
+ * @fn: Function to call on each busy command
+ * @priv: Data pointer passed to @fn
+ **/
Can you add the context information from the commit log to the kerneldoc
comment her?
Yes.
+typedef bool (scsi_host_busy_iter_fn)(struct scsi_cmnd *, void *, bool);
Is there much of a point in having this typedef?
Hmm. Idea was to save typing, but as it's being used only once I'll drop
it for the next round.
+
+void scsi_host_busy_iter(struct Scsi_Host *,
+ scsi_host_busy_iter_fn *fn, void *priv);
Any reason to spell out to argument names, but not the third one?
Probably not. Will be fixing it up.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
