Re: [PATCH 10/13] scsi: add scsi_host_busy_iter()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +/**
> + * scsi_host_busy_iter - Iterate over all busy commands
> + * @shost:	Pointer to Scsi_Host.
> + * @fn:		Function to call on each busy command
> + * @priv:	Data pointer passed to @fn
> + **/

Can you add the context information from the commit log to the kerneldoc
comment her?

> +typedef bool (scsi_host_busy_iter_fn)(struct scsi_cmnd *, void *, bool);

Is there much of a point in having this typedef?

> +
> +void scsi_host_busy_iter(struct Scsi_Host *,
> +			 scsi_host_busy_iter_fn *fn, void *priv);

Any reason to spell out to argument names, but not the third one?



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux