On Thu, Feb 06, 2020 at 01:50:32PM +0100, Martin Wilck wrote: > On Thu, 2020-02-06 at 13:33 +0100, Daniel Wagner wrote: > > Are you sure you got all the necessary places fixed up? > > > > I tend to say we should add > > > > if (!ha->flags.fw_started) > > return QLA_FUNCTION_FAILED; > > > > do qla2x00_mailbox_command() and handle the errors one by one. Just > > an > > idea. > > I had that idea too. I even tried it out. IIRC it's not that easy. Some > commands need to be sent to the mailbox even in shut-down state > (MBC_EXECUTE_FIRMWARE, for example?). I admit I didn't dare going down > the path you're suggesting, I thought it had quite a potential to cause > regressions. Yes, this certainly causing regressions. This patch is using the blacklist approach which is probably introducing less regression. But I think for finding all the right spots the white listing approach is better. Maybe only during development phase. Just an idea. > Did you mean this as a negative review, or rather an additional > suggestion? This patch clearly improves things. So yes, I approve. Reviewed-by: Daniel Wagner <dwagner@xxxxxxx> Thanks, Daniel
