Hi Martin,
On Wed, Feb 05, 2020 at 10:44:20PM +0100, mwilck@xxxxxxxx wrote:
> From: Martin Wilck <mwilck@xxxxxxxx>
>
> Since commit 45235022da99 ("scsi: qla2xxx: Fix driver unload by shutting down chip"),
> it is possible that FC commands are scheduled after the adapter firmware
> has been shut down. IO sent to the firmware in this situation hangs
> indefinitely. Avoid this for the LOGO code path that is typically taken
> when adapters are shut down.
>
> Fixes: 45235022da99 ("scsi: qla2xxx: Fix driver unload by shutting down chip")
> Signed-off-by: Martin Wilck <mwilck@xxxxxxxx>
> Reviewed-by: Roman Bolshakov <r.bolshakov@xxxxxxxxx>
Just to understand it correctly: 45235022da99 ("scsi: qla2xxx: Fix
driver unload by shutting down chip") is saying FW is not able to
shutdown propably and therefore we kill it first and still try to do
some cleanup.
Are you sure you got all the necessary places fixed up?
I tend to say we should add
if (!ha->flags.fw_started)
return QLA_FUNCTION_FAILED;
do qla2x00_mailbox_command() and handle the errors one by one. Just an
idea.
Thanks,
Daniel
