Hi Avri, On Thu, Feb 6, 2020 at 11:08 PM Avri Altman <Avri.Altman@xxxxxxx> wrote: > > > > > > Hi Avi, > > > > On Thu, Feb 6, 2020 at 9:48 PM Avi Shchislowski > > <Avi.Shchislowski@xxxxxxx> wrote: > > > > > > As it become evident that the hwmon is not a viable option to implement > > ufs thermal notification, I would appreciate some concrete comments of this > > series. > > > > That isn't my reading of this thread. > > > > You have two options: > > 1. extend drivetemp if that makes sense for this particular application. > > 2. follow the model of other devices that happen to have a built-in > > temperature sensor and expose the hwmon compatible attributes as a > > subdevice > > > > It appears that option 1 isn't viable, so what about option 2? > This will require to export the ufs device management commands, > Which is privet to the ufs driver. > > This is not a viable option as well, because it will allow unrestricted access > (Including format etc.) to the storage device. > > Sorry for not making it clearer before. I should have clarified further: I meant having the UFS device register a HWMON driver using this API: https://www.kernel.org/doc/html/latest/hwmon/hwmon-kernel-api.html *Not* writing a separate HWMON driver that uses some private interface. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/
