On 2020-01-23 14:21, James Smart wrote: > + depth = simple_strtoul(buf, NULL, 0); >From Documentation/process/deprecated.rst: The :c:func:`simple_strtol`, :c:func:`simple_strtoll`, :c:func:`simple_strtoul`, and :c:func:`simple_strtoull` functions explicitly ignore overflows, which may lead to unexpected results in callers. The respective :c:func:`kstrtol`, :c:func:`kstrtoll`, :c:func:`kstrtoul`, and :c:func:`kstrtoull` functions tend to be the correct replacements, though note that those require the string to be NUL or newline terminated. Did checkpatch recommend to use kstrtoul() instead? > + return (retval < 0) ? retval : count; Are the parentheses necessary in this expression? Thanks, Bart.
