Re: [PATCH v2 2/3] scsi: add shost helper to set max queue depth on all of its devices

[Bart Van Assche <bvanassche@xxxxxxx>]

On 2020-01-23 14:21, James Smart wrote:
>  /**
> + * shost_change_max_queue_depths -  helper to walk all devices on a
                                     ^^
                  a single space here is probably sufficient?

> +	if (!shost->hostt->change_queue_depth)
> +		return -ENOTSUPP;

ENOTSUPP is defined in include/linux/errno.h so that's a kernel-internal
error code. I think only error codes from
include/uapi/asm-generic/errno*.h should be returned to user space.

> +	if (depth < 1 || depth > shost->can_queue)
> +		return -EINVAL;

Thanks,

Bart.