Bart, >> + if (scsi_report_opcode(sdev, buffer, SD_BUF_SIZE, WRITE_SAME_16) == 1 || >> + sd_default_support_ws16) >> sdkp->ws16 = 1; >> >> if (scsi_report_opcode(sdev, buffer, SD_BUF_SIZE, WRITE_SAME) == 1) > > Should this be fixed using the quirk mechanism instead of introducing a > new kernel module parameter? Kernel module parameters apply to all SCSI > disk devices irrespective of their vendor and model. The quirk mechanism > can be used to introduce special behavior for certain disk models and > types. Yes, this should definitely be a blacklist option. Although I'd obviously encourage the vendor to implement RSOC instead of working around this in the kernel. -- Martin K. Petersen Oracle Linux Engineering
