On Tue, 2006-12-05 at 21:08 -0800, Andrew Morton wrote:
> case MEDIUM_ERROR:
> + if (sshdr.asc == 0x11 || /* UNRECOVERED READ ERR */
> + sshdr.asc == 0x13 || /* AMNF DATA FIELD */
> + sshdr.asc == 0x14) { /* RECORD NOT FOUND */
> + return SUCCESS;
> + }
> return NEEDS_RETRY;
If the complaint is true; i.e. infinite retries, this is just a bandaid
not a fix. What it's doing is marking the unrecoverable medium errors
for no retry. However, what we really need to know is why NEEDS_RETRY
isn't terminating after its allotted number of retries. Can we please
have a trace of this?
> - if (scsi_end_request(cmd, 1, good_bytes, result == 0) == NULL)
> + if (good_bytes &&
> + scsi_end_request(cmd, 1, good_bytes, result == 0) == NULL)
> return;
What exactly is this supposed to be doing? its result is identical to
the code it's replacing (because of the way scsi_end_request() processes
its second argument), so it can't have any effect on the stated problem.
James
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
