--- Michael Reed <mdr@xxxxxxx> wrote:
> Luben Tuikov wrote:
> ...snip...
> > This statement in scsi_io_completion() causes the infinite retry loop:
> > if (scsi_end_request(cmd, 1, good_bytes, !!result) == NULL)
> > return;
>
> The code in 2.6.19 is "result==0", not "!!result", which is logically
> the same as "result!=0". Did you mean to change the logic here?
> Am I missing something?
Hmm, I think my trees have !!result from an earlier patch I posted.
In this case it would appear that the second chunk of the patch
wouldn't be necessary, since result==0 would be false, and it
wouldn't retry.
Luben
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
