On 2019-11-13 07:29, Himanshu Madhani wrote: > On Nov 11, 2019, at 8:48 PM, Bart Van Assche <bvanassche@xxxxxxx> wrote: >> Himanshu, can you tell us which adapters and/or firmware versions need >> which version of the above code? > > All adapters with FW v4.4 will behave same. If you are running into issue with P2P connection, > it might be something different than specific to this code change. Original code in the driver was not > following firmware spec. This code is now used in initiator mode as well due to introduction of > FC-NVMe handling in the driver. Also, can you tell me what version of firmware you have on your > remote port. Hi Himanshu, My test was run on a setup with a single QLE2562 adapter with both FC ports connected directly to each other. The kernel driver identifies that adapter as follows: ISP2532: PCIe (5.0GT/s x8) @ 0000:00:0a.0 hdma+ host#=12 fw=8.07.00 (90d5). Please let me know if you need more information. Thanks, Bart.