On Fri, Aug 30, 2019 at 02:10:42PM +1000, Dave Chinner wrote: > > reiserfs_file_release(): > > tries to return an error if it can't free preallocated blocks. > > > > xfs_release(): > > similar to the previous case. > > Not quite right. XFS only returns an error if there is data > writeback failure or filesystem corruption or shutdown detected > during whatever operation it is performing. > > We don't really care what is done with the error that we return; > we're just returning an error because that's what the function > prototype indicates we should do... I thought that xfs_release() and friends followed the prototypes you had on IRIX, while xfs_file_release() et.al. were the impedance-matching layer for Linux. Oh, well...