Re: [PATCH v4 07/22] sg: move header to uapi section

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2019-08-29 7:15 a.m., kbuild test robot wrote:
Hi Douglas,

Thank you for the patch! Yet something to improve:

Hi Kbuild,
Both of us have something to improve. I should fix my code, but it
was correct before you told me to fix it last time!

The change that caused this error is on line 35 of include/uapi/scsi/sg.h:
    #include <uapi/linux/bsg.h>

which is indeed incorrect since no other header under include/uapi
has "uapi" in the path of one of its embedded includes. So the rule seems
to be that header files under the uapi directory implicitly refer to
other headers under the uapi directory when they "#include <filename>".

However the change in my code was a result of this kbuild report from
version 2 of this patchset:
   https://www.spinics.net/lists/linux-scsi/msg132432.html

And that earlier error report seems incorrect and indicates that your
build tree is misconfigured with respect to this directory:
    include/uapi/scsi/

The failure shown in msg132432.html indicates that when your tree resolved
this line in include/uapi/scsi/sg.h :
    #include <linux/bsg.h>

that it incorrectly included
    include/linux/bsg.h
instead of
    include/uapi/linux/bsg.h

If you concur and fix this issue, kindly add the following tag
Reported-by: Douglas Gilbert <dgilbert@xxxxxxxxxxxx>


[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc6 next-20190828]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Douglas-Gilbert/sg-add-v4-interface/20190829-123646
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
reproduce:
         # save the attached .config to linux build tree
         make ARCH=x86_64

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

    In file included from <command-line>:32:0:
./usr/include/scsi/sg.h:35:10: fatal error: uapi/linux/bsg.h: No such file or directory
     #include <uapi/linux/bsg.h>
              ^~~~~~~~~~~~~~~~~~
    compilation terminated.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux