Hi Avri, On Thu, 2019-07-25 at 16:52 +0800, Stanley Chu wrote: > Hi Avri, > > On Thu, 2019-07-25 at 07:54 +0000, Avri Altman wrote: > > Stanly, > > > > > > > > Currently bits in hba->outstanding_tasks are cleared only after their > > > corresponding task management commands are successfully done by > > > __ufshcd_issue_tm_cmd(). > > > > > > If timeout happens in a task management command, its corresponding > > > bit in hba->outstanding_tasks will not be cleared until next task > > > management command with the same tag used successfully finishes. > > I'm sorry - I still don't understand why you just can't release the tag either way, > > Just like we do in device management queries tags, > > Instead of adding all this unnecessary code. > > > > I will not object to your series - > > just step down and let other people review you patches. Sorry for late response due to these busy days. I just got your point and agreed with you: previous proposal may be too tricky. Simple always wins. So I will provide a short solution in next version. Many thanks! Stanley
