Hi all, the fcoe vn2vn code is using the 'fc_rport_priv' structure as argument to its internal function, but is really expecting a struct fcoe_rport to immediately follow this one. This is not only confusing but also an error for new compilers. So clean up the usage by embedding fc_rport_priv into fcoe_rport, and use the fcoe_rport structure wherever possible. This patchset also contains some minor whitespace cleanups for libfc.h. As usual, comments and reviews are welcome. Changes to v1: - Drop patch to remove lld_event_callback Changes to v2: - Include reviews from Christoph Hannes Reinecke (3): libfc: Whitespqce cleanup in libfc.h fcoe: Embed fc_rport_priv in fcoe_rport structure fcoe: pass in fcoe_rport structure instead of fc_rport_priv drivers/scsi/fcoe/fcoe_ctlr.c | 138 ++++++++++++++++++++---------------------- drivers/scsi/libfc/fc_rport.c | 5 +- include/scsi/libfc.h | 52 ++++++++-------- include/scsi/libfcoe.h | 1 + 4 files changed, 96 insertions(+), 100 deletions(-) -- 2.16.4
