On 2019-08-12 10:23 a.m., Christoph Hellwig wrote:
On Wed, Aug 07, 2019 at 01:42:37PM +0200, Douglas Gilbert wrote:
+ unsigned long fdev_bm[1]; /* see SG_FDEV_* defines above */
No need for the array of one here.
Justification here:
https://www.spinics.net/lists/linux-scsi/msg132477.html
+#define SG_IS_DETACHING(sdp) test_bit(SG_FDEV_DETACHING, (sdp)->fdev_bm)
+#define SG_HAVE_EXCLUDE(sdp) test_bit(SG_FDEV_EXCLUDE, (sdp)->fdev_bm)
No real need for these wrappers.
True of all wrappers. Again, these wrappers are fighting the tyranny of
checkpatch.pl
Otherwise this looks sane to me.
