On 2019-08-12 10:31 a.m., Christoph Hellwig wrote:
On Wed, Aug 07, 2019 at 01:42:41PM +0200, Douglas Gilbert wrote:
Add sg_allow_if_err_recover() to do checks common to several entry
points. Replace retval with either res or ret. Rename
sg_finish_rem_req() to sg_finish_scsi_blk_rq(). Rename
sg_new_write() to sg_submit(). Other cleanups triggered by
checkpatch.pl .
I think you want to split adding a new helper from random renames.
"Random" is in the eye of the beholder. Take sg_new_write(), 20
years ago that referred to the newly introduced v3 interface. Its
a bit misleading to leave that name in place when the whole point
of the patchset is to add the v4 interface.
I don't understand why reviewers don't defer to a driver author and/or
maintainer in the cases of function and variable names. 20 years of
pigeonhole patches and kernel interface changes corrupt the original
naming and style of a driver. There are more significant things to
criticize if one looked deeper.
Doug Gilbert
