Hi Douglas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.3-rc1 next-20190726] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Douglas-Gilbert/sg-add-v4-interface/20190727-170351 config: x86_64-randconfig-s1-07261000 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): In file included from include/uapi/scsi/sg.h:35:0, from <command-line>:0: >> include/linux/bsg.h:31:10: warning: 'struct device' declared inside parameter list struct device *parent) ^ >> include/linux/bsg.h:31:10: warning: its scope is only this definition or declaration, which is probably not what you want >> include/linux/bsg.h:31:10: warning: 'struct request_queue' declared inside parameter list include/linux/bsg.h:35:48: warning: 'struct request_queue' declared inside parameter list static inline void bsg_unregister_queue(struct request_queue *q) ^ vim +31 include/linux/bsg.h 3d6392cf Jens Axboe 2007-07-09 24 17cb960f Christoph Hellwig 2018-03-13 25 int bsg_register_queue(struct request_queue *q, struct device *parent, 5de815a7 Christoph Hellwig 2018-05-29 26 const char *name, const struct bsg_ops *ops); 17cb960f Christoph Hellwig 2018-03-13 27 int bsg_scsi_register_queue(struct request_queue *q, struct device *parent); 17cb960f Christoph Hellwig 2018-03-13 28 void bsg_unregister_queue(struct request_queue *q); 3d6392cf Jens Axboe 2007-07-09 29 #else 17cb960f Christoph Hellwig 2018-03-13 30 static inline int bsg_scsi_register_queue(struct request_queue *q, 17cb960f Christoph Hellwig 2018-03-13 @31 struct device *parent) :::::: The code at line 31 was first introduced by commit :::::: 17cb960f29c29ee07bf6848ada3265f4be55972e bsg: split handling of SCSI CDBs vs transport requeues :::::: TO: Christoph Hellwig <hch@xxxxxx> :::::: CC: Jens Axboe <axboe@xxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
