Re: [PATCH] scsi: aha1740: Use !x in place of NULL comparisons

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: James Bottomley <jejb@xxxxxxxxxxxxx>
Subject: Re: [PATCH] scsi: aha1740: Use !x in place of NULL comparisons
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Thu, 11 Jul 2019 20:38:45 -0400
Cc: Keyur Patel <iamkeyur96@xxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <1562889124.2915.5.camel@linux.ibm.com> (James Bottomley's message of "Thu, 11 Jul 2019 16:52:04 -0700")
Organization: Oracle Corporation
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux)

James,

> I also don't really think the replacement adds anything to readability,
> so it should probably be removed from the checkpatch warnings.

I agree.

-- 
Martin K. Petersen	Oracle Linux Engineering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH] scsi: aha1740: Use !x in place of NULL comparisons
  - From: Keyur Patel
- Re: [PATCH] scsi: aha1740: Use !x in place of NULL comparisons
  - From: James Bottomley

Prev by Date: Re: [PATCH V2 1/3] pm80xx : Fixed kernel panic during error recovery for SATA drive.
Next by Date: Re: [PATCH 1/2] scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade
Previous by thread: Re: [PATCH] scsi: aha1740: Use !x in place of NULL comparisons
Next by thread: [PATCH] scsi: g_NCR5380: Use !x in place of NULL comparisons
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]

Powered by Linux