On Thu, 2019-07-11 at 19:48 -0400, Keyur Patel wrote: > Change (x == NULL) to !x and (x != NULL) to x, to fix > following checkpatch.pl warnings: > CHECK: Comparison to NULL could be written "!x". This is one of our significantly older drivers. We try not to touch it unless we really have to, so I'd rather not have patches like this applied to it. I also don't really think the replacement adds anything to readability, so it should probably be removed from the checkpatch warnings. Thanks, James