Alexis Bruemmer wrote: > Domain device is freed but the port dev list is not adjusted on some > discovery errors. Module unload will Oops if this happens. It'll still oops; sas_ex_discover_end_dev needs to be updated to know that it needn't call sas_rphy_free if the device-specific discovery functions fail. This patch should fix that case too. -- Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c index 4cc7457..a38d05b 100644 --- a/drivers/scsi/libsas/sas_expander.c +++ b/drivers/scsi/libsas/sas_expander.c @@ -711,7 +711,6 @@ static struct domain_device *sas_ex_disc out_list_del: list_del(&child->dev_list_node); - sas_rphy_free(rphy); out_free: sas_port_delete(phy->port); out_err: - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
