Alexis Bruemmer wrote: > One question that remains with this patch is whether or not > sas_get_port_device should be moved into sas_discover_{sas,expander} to > ensure that the rphy struct is allocated and freed-in-error in the same > function It looks as though we could move the parts of sas_get_port_device() that deal with rphy allocation/initialization into the sas_discover_{sata,sas,expander} functions? I don't know for sure; I could be missing some subtlety that requires the sas_rphy creation to be in sas_get_port_device. --D - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html