Re: [PATCH 1/3] scsi: Do not allow user space to change the SCSI device state into SDEV_BLOCK

To: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxxx>
Subject: Re: [PATCH 1/3] scsi: Do not allow user space to change the SCSI device state into SDEV_BLOCK
From: James Smart <james.smart@xxxxxxxxxxxx>
Date: Fri, 7 Jun 2019 08:46:07 -0700
Cc: Bart Van Assche <bvanassche@xxxxxxx>, Hannes Reinecke <hare@xxxxxxx>, "James E . J . Bottomley" <jejb@xxxxxxxxxxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>, Johannes Thumshirn <jthumshirn@xxxxxxx>
In-reply-to: <yq1tvd1lgql.fsf@oracle.com>
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0

On 6/7/2019 5:30 AM, Martin K. Petersen wrote:

Hannes,

So let's restrict userspace to only ever setting 'RUNNING' or
'OFFLINE'.  None of the other states make sense to set from userspace.

Yes, please!


+1 for me too

Follow-Ups:
- Re: [PATCH 1/3] scsi: Do not allow user space to change the SCSI device state into SDEV_BLOCK
  - From: Hannes Reinecke

References:
- [PATCH 0/3] Avoid that .queuecommand() gets called for a quiesced SCSI device
  - From: Bart Van Assche
- [PATCH 1/3] scsi: Do not allow user space to change the SCSI device state into SDEV_BLOCK
  - From: Bart Van Assche
- Re: [PATCH 1/3] scsi: Do not allow user space to change the SCSI device state into SDEV_BLOCK
  - From: Hannes Reinecke
- Re: [PATCH 1/3] scsi: Do not allow user space to change the SCSI device state into SDEV_BLOCK
  - From: Bart Van Assche
- Re: [PATCH 1/3] scsi: Do not allow user space to change the SCSI device state into SDEV_BLOCK
  - From: Hannes Reinecke
- Re: [PATCH 1/3] scsi: Do not allow user space to change the SCSI device state into SDEV_BLOCK
  - From: Martin K. Petersen