[replying to an old thread] On Sun, 8 Apr 2018 11:57:18 +0800, Zhang Zhuoyu wrote: > > On Thu, 5 Apr 2018 13:12:12 +0200, David Disseldorp wrote: > > > > > > -CONFIGFS_ATTR_RO(target_stat_tgt_port_, in_cmds); > > > > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, tx_cmds); > > > > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, rx_cmds); > > > > > > I don't think the in_cmds metric should be deleted here. It could be > > > calculated on the fly via tx_cmds + rx_cmds + nodata_cmds. > > > > @Zhang Zhuoyu: How about something like the following? > > https://git.samba.org/?p=ddiss/linux.git;a=commitdiff;h=73723ccf433424721 > > 830797d70cfb88d4596e0fc > > > > Mmm... This patch is much better. > Looks good to me. Looks like I never followed up with a proper submission for this patch. I'll do so later today. Cheers, David
