Re: [PATCH 2/2] sd: Inline sd_probe_part2()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 3/21/19 2:39 PM, Bart Van Assche wrote:
> On Wed, 2019-03-20 at 20:35 -0400, Martin K. Petersen wrote:
>> Bart,
>>
>>> You are right of course. The reason I would like to inline that
>>> function is because it was essential in the past to have that code as
>>> a separate function but after patch 1/2 inlining that function makes
>>> sd_probe() easier to read.  Martin, do you want me to resubmit this
>>> patch series with an updated commit message or do you rather prefer to
>>> update the commit message yourself?
>>
>> Just mail me a reworded blurb.
> 
> Hi Martin,
> 
> How about the following:
> -----------------------------------------------------------------------
> Make sd_probe() easier to read by inlining sd_probe_part2(). This patch
> does not change any functionality.
> -----------------------------------------------------------------------
> Thanks,
> 
> Bart.
> 

Given the updated blurb:

Reviewed-by: Lee Duncan <lduncan@xxxxxxxx>



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux