On 1/26/2019 1:43 AM, Hannes Reinecke wrote:
Hmm. Wouldn't it be better here to set lpfc_ncmd->nvmeCmd to NULL first, then release the lock, and _then_ call nCmd->done()? With the current code there might be a risk of accidental command starvation, as ->done() is called before the command itself is being released, hence the old command will not be available for re-use after the call to ->done().Otherwise it looks okay. Cheers, Hannes
Agreed. reworked this. -- james
