Re: [PATCH v3 11/26] lpfc: Synchronize hardware queues with SCSI MQ interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/26/2019 1:16 AM, Hannes Reinecke wrote:
+    } else
+        shost->nr_hw_queues = 1;
      /*
       * Set initial can_queue value since 0 is no longer supported and

Why do you restrict full mq support to SLE-4?
The original code seems to imply that older revisions would be able to do mq, too...

Can you add a comment here why older revisions don't support it?

Other than that:

Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes

Because SLi-3 has small number of queues (3) and only 1 is used FCP traffic. Yes, the prior code had an error that had set nr_hw_queues > 1.

I have added a comment on SLi-3 to the patch.

-- james



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux