On 01/10/2019 07:07 AM, Christoph Hellwig wrote: > On Wed, Jan 09, 2019 at 06:58:56PM -0800, Tyrel Datwyler wrote: >> While mapping DMA for scatter list when a scsi command is queued the >> existing call to dma_alloc_coherent() in our map_sg_data() function >> passes zero for the gfp_flags parameter. We are most definitly in atomic >> context at this point as queue_command() is called in softirq context >> and further we have a spinlock holding the scsi host lock. >> >> Fix this by passing GFP_ATOMIC to dma_alloc_coherent() to prevent any >> sort of sleeping in atomic context deadlock. > > This is a pretty clear sign you should not be using dma_alloc_coherent > to start with. GFP_ATOMIC support in many of the implementations either > doesn't work at all or is severly constrained. Given that the > descriptor is written by the OS and read by the hardware exactly once > there is no point in having the coherent mapping to start with. > This allocation isn't a single use allocation. The driver is just lazy about allocating our ext_list area for large SG lists (ie. SG_ALL). When the driver was first written it only supported up to 10 indirect SRP buffers. James Bottemley added the large SG support back in 2005 with the commit referenced here in the fixes tag "4dddbc26c389". We only allocate the ext_list when we come across a SG list requiring more than 10 indirect buffers. Once allocated we will reuse if already allocated. -Tyrel
