On Wed, Jan 09, 2019 at 06:58:56PM -0800, Tyrel Datwyler wrote: > While mapping DMA for scatter list when a scsi command is queued the > existing call to dma_alloc_coherent() in our map_sg_data() function > passes zero for the gfp_flags parameter. We are most definitly in atomic > context at this point as queue_command() is called in softirq context > and further we have a spinlock holding the scsi host lock. > > Fix this by passing GFP_ATOMIC to dma_alloc_coherent() to prevent any > sort of sleeping in atomic context deadlock. This is a pretty clear sign you should not be using dma_alloc_coherent to start with. GFP_ATOMIC support in many of the implementations either doesn't work at all or is severly constrained. Given that the descriptor is written by the OS and read by the hardware exactly once there is no point in having the coherent mapping to start with.
