Christoph, >> Allow user to selectively enable/disable DIF/DIX protection >> capabilities mask. > > I really hate having knows for this in various drivers. Can't we have > a way to do this genericly? The module parameter is really just a debugging tool (I use it to force DIX0 operation with T10 PI storage so I don't have to have keep legacy-formatted disks available for testing). Normal users should use read_verify and write_generate to enable/disable DIX. If we make the prot mask a tunable, we'll have to shuffle the integrity profile registration over to revalidate and remember the user override. And then trigger an MD/DM restack. Certainly doable, but it hasn't seemed worth the hassle to go there. -- Martin K. Petersen Oracle Linux Engineering