Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:32 PM, Gustavo A. R. Silva wrote:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> --- drivers/scsi/osd/osd_initiator.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c index 60cf7c5eb880..cb26f26d5ec1 100644 --- a/drivers/scsi/osd/osd_initiator.c +++ b/drivers/scsi/osd/osd_initiator.c @@ -1849,6 +1849,7 @@ int osd_req_decode_sense_full(struct osd_request *or, 32, 1, dump, sizeof(dump), true); OSD_SENSE_PRINT2("response_integrity [%s]\n", dump); } + /* fall through */ case osd_sense_attribute_identification: { struct osd_sense_attributes_data_descriptor @@ -1879,7 +1880,7 @@ int osd_req_decode_sense_full(struct osd_request *or, attr_page, attr_id); } } - /*These are not legal for OSD*/ + /* fall through - These are not legal for OSD */ case scsi_sense_field_replaceable_unit: OSD_SENSE_PRINT2("scsi_sense_field_replaceable_unit\n"); break;