On 11/15/2018 4:52 AM, Hannes Reinecke wrote:
On 11/14/18 6:13 PM, Ewan D. Milne wrote:
On Tue, 2018-11-13 at 09:49 -0800, Bart Van Assche wrote:
On Tue, 2018-11-13 at 17:38 +0000, Madhani, Himanshu wrote:
On Nov 13, 2018, at 6:23 AM, Bart Van Assche <bvanassche@xxxxxxx>
wrote:
On Tue, 2018-11-13 at 01:02 +0000, Madhani, Himanshu wrote:
I see other drivers also use similar information populated for NVMe
Connection at boot time.
Hi Himanshu,
Which other drivers are you referring to?
Thanks,
Bart.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/dri
vers/scsi/lpfc/lpfc_attr.c
Hello James,
Please either move the information exported by lpfc_nvme_info_show()
into
debugfs or split the information exported by that function into
multiple
sysfs attributes. Otherwise you will get flamed by Greg KH as soon
as he
encounters that code because of not following the rules explained in
Documentation/filesystems/sysfs.txt.
Bart.
Better yet, is there some way we could get at least the connection
information needed for discovery moved into the NVMe/FC transport
layer so that we don't need to have separate implementations that
have to be parsed?
Sigh.
It's already been solved, there's no need for this attribute.
nvme-fc already sends a uevent whenever a new nvme rport is attached,
(check nvme_fc_register_remoteport()->nvme_fc_signal_discovery_scan().
James Smart added a sysfs entry for retriggering these uevents, and
I've posted a set of scripts (... at least I think I did :-) utilizing
those.
Please do _NOT_ do this; better rely on common mechanisms here.
And please, next time please cc linux-nvme so that we can track it
better.
Cheers,
Hannes
Yes - the attribute in lpfc needs to go. It's currently a temporary
thing until we merge the nvme and scsi transports and informational only.
It *is not* used for autoconnect. The nvme fc transport automatically
generates udev events upon nvme remoteport registrations and, as Hannes
points out, we added a transport attribute to regenerate connect events
for a host:
http://git.infradead.org/nvme.git/commit/97faec531460c949d7120672b8c77e2f41f8d6d7
-- james
