On Tue, 2018-11-13 at 17:38 +-0000, Madhani, Himanshu wrote: +AD4 On Nov 13, 2018, at 6:23 AM, Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4 wrote: +AD4 +AD4 On Tue, 2018-11-13 at 01:02 +-0000, Madhani, Himanshu wrote: +AD4 +AD4 +AD4 I see other drivers also use similar information populated for NVMe +AD4 +AD4 +AD4 Connection at boot time. +AD4 +AD4 +AD4 +AD4 Hi Himanshu, +AD4 +AD4 +AD4 +AD4 Which other drivers are you referring to? +AD4 +AD4 +AD4 +AD4 Thanks, +AD4 +AD4 +AD4 +AD4 Bart. +AD4 +AD4 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/dri +AD4 vers/scsi/lpfc/lpfc+AF8-attr.c Hello James, Please either move the information exported by lpfc+AF8-nvme+AF8-info+AF8-show() into debugfs or split the information exported by that function into multiple sysfs attributes. Otherwise you will get flamed by Greg KH as soon as he encounters that code because of not following the rules explained in Documentation/filesystems/sysfs.txt. Bart.