From: James Bottomley > Sent: 13 November 2018 16:11 > > On Tue, 2018-11-13 at 16:53 +0100, Johannes Thumshirn wrote: > > On 13/11/2018 16:44, John Garry wrote: > > > On 13/11/2018 15:08, Sabyasachi Gupta wrote: > [...] > > > > - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * > > > > PAGE_SIZE)); > > > > + fnic_trace_buf_p = (unsigned long)vzalloc((trace_max_pages * > > > > + PAGE_SIZE)); > > > > > > If you remove the extra brackets in vzalloc() argument then you may > > > not spill onto the next line. > > > > And remove the unnecessary cast. vzalloc() (just like vmalloc()) > > returns a void*, so no reason to cast it. > > This is incorrect advice: there's no need to cast it to other *pointer* > types, but if you cast it to a non-pointer type (which this is doing) > the compiler will complain if there is no explicit cast. The real question is why is this code using 'unsigned long' to hold pointers? Never mind why it is allocating a large memory block then setting up another array with pointers to every 64 bytes down it. Also why default to 16 * PAGE_SIZE - that is silly if pages are big. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
