On 13/11/2018 17:22, Sabyasachi Gupta wrote: > On Tue, Nov 13, 2018 at 9:46 PM Johannes Thumshirn <jthumshirn@xxxxxxx> wrote: >> >> On 13/11/2018 17:11, James Bottomley wrote: >>> This is incorrect advice: there's no need to cast it to other *pointer* >>> types, but if you cast it to a non-pointer type (which this is doing) >>> the compiler will complain if there is no explicit cast. > shall I leave the typecast as it is? Yes, sorry for not looking at it deeply enough. -- Johannes Thumshirn SUSE Labs jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850