On Mon, 2018-11-12 at 19:31 +0000, John Garry wrote: > On 12/11/2018 18:58, Joe Perches wrote: > > > > +#define pr_fmt(fmt) "sas: " fmt > > > > > > > > Some other subsystem may try to include this header, and gets its > > > > message prefix overwritten. Just a consequence for doing something bad, > > > > right? > > Right. > > > > And as this file is internal to drivers/scsi/libsas > > that seems very unlikely to occur. > > > > It also might useful to use the common debugging > > mechanisms and convert SAS_DPRINTK to pr_debug > > which would use the same #define pr_fmt. > > > > OK, I will try to put this all together as a marginally wider scope tidy-up. Thanks. Another thing that could be done is to change the #define pr_fmt(fmt) to KBUILD_MODNAME as that would prefix "libsas" instead of just "sas". I think that would be better but I didn't do that as it should be in a separate patch.