Re: [PATCH 3/5] qla1280: use lower_32_bits and upper_32_bits instead of reinventing them

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/18/18 9:47 PM, Bart Van Assche wrote:
On 10/18/18 6:03 AM, Christoph Hellwig wrote:
@@ -1790,8 +1783,8 @@ qla1280_load_firmware_dma(struct scsi_qla_host *ha)
          mb[4] = cnt;
          mb[3] = ha->request_dma & 0xffff;
          mb[2] = (ha->request_dma >> 16) & 0xffff;
-        mb[7] = pci_dma_hi32(ha->request_dma) & 0xffff;
-        mb[6] = pci_dma_hi32(ha->request_dma) >> 16;
+        mb[7] = upper_32_bits(ha->request_dma) & 0xffff;
+        mb[6] = upper_32_bits(ha->request_dma) >> 16;

Have you considered to use put_unaligned_be32()?

Answering my own question: put_unaligned_be32() is inappropriate here because it stores each pair of bytes in the opposite order of the current code on little endian systems.

Bart.



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux