Re: [PATCH 3/5] qla1280: use lower_32_bits and upper_32_bits instead of reinventing them

[Bart Van Assche <bvanassche@xxxxxxx>]

On 10/18/18 6:03 AM, Christoph Hellwig wrote:
> @@ -1790,8 +1783,8 @@ qla1280_load_firmware_dma(struct scsi_qla_host *ha)
>   		mb[4] = cnt;
>   		mb[3] = ha->request_dma & 0xffff;
>   		mb[2] = (ha->request_dma >> 16) & 0xffff;
> -		mb[7] = pci_dma_hi32(ha->request_dma) & 0xffff;
> -		mb[6] = pci_dma_hi32(ha->request_dma) >> 16;
> +		mb[7] = upper_32_bits(ha->request_dma) & 0xffff;
> +		mb[6] = upper_32_bits(ha->request_dma) >> 16;

Hi Christoph,

Have you considered to use put_unaligned_be32()?

Thanks,

Bart.