Re: [PATCH v2 1/7] drivers/base: Fix a race condition in the device probing code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-10-18 at 07:10 +-0200, Greg Kroah-Hartman wrote:
+AD4 +AD4 diff --git a/drivers/base/dd.c b/drivers/base/dd.c
+AD4 +AD4 index edfc9f0b1180..b4212154a94b 100644
+AD4 +AD4 --- a/drivers/base/dd.c
+AD4 +AD4 +-+-+- b/drivers/base/dd.c
+AD4 +AD4 +AEAAQA -645,6 +-645,14 +AEAAQA int driver+AF8-probe+AF8-device(struct device+AF8-driver +ACo-drv, struct device +ACo-dev)
+AD4 +AD4  +AHs
+AD4 +AD4  	int ret +AD0 0+ADs
+AD4 +AD4  
+AD4 +AD4 +-	/+ACo
+AD4 +AD4 +-	 +ACo Several callers check the driver pointer without holding the
+AD4 +AD4 +-	 +ACo device mutex. Hence check the driver pointer again while holding
+AD4 +AD4 +-	 +ACo the device mutex.
+AD4 +AD4 +-	 +ACo-/
+AD4 +AD4 +-	if (dev-+AD4-driver)
+AD4 +AD4 +-		return dev-+AD4-driver +AD0APQ drv+ADs
+AD4 
+AD4 I do not understand, who is calling probe twice?  What is the sequence
+AD4 of events that is causing that error message being printed out?  Wh is
+AD4 not grabbing the mutex properly?

Hi Greg,

If I drop patch 3/7 from my patch series and use Alexander Duyck's patches
instead I don't need this patch anymore. So I don't think we have to spend
more time on this patch.

Thanks,

Bart.




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux