Re: [PATCH v2 3/7] drivers/base: Probe devices concurrently if requested by the driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-10-18 at 08:25 -0700, Alexander Duyck wrote:
+AD4 On 10/17/2018 5:54 PM, Dan Williams wrote:
+AD4 +AD4 On Wed, Oct 17, 2018 at 4:41 PM Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4 wrote:
+AD4 +AD4 +AD4 
+AD4 +AD4 +AD4 Instead of probing devices sequentially in the PROBE+AF8-PREFER+AF8-ASYNCHRONOUS
+AD4 +AD4 +AD4 mode, scan devices concurrently. This helps when the wall clock time for
+AD4 +AD4 +AD4 a single probe is significantly above the CPU time needed for a single
+AD4 +AD4 +AD4 probe, e.g. when scanning SCSI LUNs over a storage network.
+AD4 +AD4 
+AD4 +AD4 Alex had a similar patch here +AFs-1+AF0 that I don't think has been accepted
+AD4 +AD4 yet, in any event some collaboration is needed:
+AD4 +AD4 
+AD4 +AD4 +AFs-1+AF0: https://lkml.org/lkml/2018/9/27/14
+AD4 
+AD4 The patch set referenced is a little out of date. The latest set is:
+AD4 https://lore.kernel.org/lkml/20181015150305.29520.86363.stgit+AEA-localhost.localdomain/
+AD4 
+AD4 I'm also not quite sure what the point of this patch is. I don't think 
+AD4 it is doing what it says it is doing. From what I can tell it is just 
+AD4 allowing the driver init code to ignore if the driver wants to be probed 
+AD4 asynchronously or not. Further comments inline below.

Hi Alexander,

Thanks for the pointer to the latest version of your patch series. I was not
yet aware of your work when I posted this patch series. Now that I have had a
look at your patch series I like your approach better than what I did in this
patch. Since it could take a while before agreement is reached about the async
domain patches in the same patch series, how about you submitting patches 3/6
and 4/6 from your patch series to Greg for kernel version v4.20? If I drop
the driver core patches from my patch series and replace these with your
driver core patches I achieve the same results. If you Cc me when you resubmit
these patches I will review them.

Thanks,

Bart.




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux